Fix downcasting bug in local_[mul|div]_switch_sink rewrite
#1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
local_[mul|div]_switch_sink rewrite
ricardoV94
force-pushed
the
zero_sink_rewrite_bug
branch
from
956b73f to
faa1abb
Compare
ricardoV94
commented
Oct 31, 2024
| @@ -2115,7 +2117,6 @@ def test_local_mul_switch_sink(self): | |||
| f = self.function_remove_nan([x], pytensor.gradient.grad(y, x), self.mode) | |||
| assert f(5) == 1, f(5) | |||
|
|
|||
| @pytest.mark.slow | |||
There was a problem hiding this comment.
It was not particularly slow and not slower than the test above
ricardoV94
force-pushed
the
zero_sink_rewrite_bug
branch
from
faa1abb to
ecf9829
Compare
ricardoV94
changed the title
local_[mul|div]_switch_sink rewritelocal_[mul|div]_switch_sink rewrite
ricardoV94
force-pushed
the
zero_sink_rewrite_bug
branch
from
ecf9829 to
e664da8
Compare
ricardoV94
force-pushed
the
zero_sink_rewrite_bug
branch
from
e664da8 to
2dffc91
Compare
ricardoV94
force-pushed
the
zero_sink_rewrite_bug
branch
from
2dffc91 to
096f285
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1059 +/- ##
==========================================
- Coverage 81.95% 81.95% -0.01%
==========================================
Files 182 182
Lines 47872 47857 -15
Branches 8618 8619 +1
==========================================
- Hits 39233 39219 -14
Misses 6472 6472
+ Partials 2167 2166 -1
|
twiecki
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1037
It also refactors the two rewrites to avoid so much duplicated code
The fix revealed some subtle bugs in the C implementation of Scalar Ops with negative literal constants, that were also fixed.
📚 Documentation preview 📚: https://pytensor--1059.org.readthedocs.build/en/1059/